[haiku-bugs] Re: [Haiku] #9193: Sniffer rule for video/mp2t too simple

  • From: "phoudoin" <trac@xxxxxxxxxxxx>
  • Date: Fri, 05 Apr 2013 08:58:52 -0000

#9193: Sniffer rule for video/mp2t too simple
-------------------------------------+-------------------------
   Reporter:  dsuden                 |      Owner:  jscipione
       Type:  bug                    |     Status:  closed
   Priority:  normal                 |  Milestone:  R1
  Component:  Preferences/FileTypes  |    Version:  R1/alpha4.1
 Resolution:  fixed                  |   Keywords:
 Blocked By:                         |   Blocking:  7935
Has a Patch:  1                      |   Platform:  All
-------------------------------------+-------------------------

Comment (by phoudoin):

 Replying to [comment:2 humdinger]:
 > Can anyone come up with a better sniffer rule? It looks like after that
 first sync byte, there isn't much to analyze (s.
 [http://en.wikipedia.org/wiki/MPEG_transport_stream#Packet wikipedia]), or
 is there?

 Our sniffer rule syntax don't support a repeat mode, otherwise a way
 better rule for MPEG files would be simply to check the sync 0x47 ('G')
 byte every 188 bytes, not just first one.

 While a repeat pattern could be hard to implement, what could be done
 quickly is to support combining patterns with & (AND), not just with |
 (OR) as today.
 That would make this rule :

 {{{
 "0.9 ('G' & [188] 'G' & [376] 'G' & [564] 'G')"
 }}}

 ...detecting better MP2+ content.

--
Ticket URL: <http://dev.haiku-os.org/ticket/9193#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: