[haiku-bugs] Re: [Haiku] #9426: Change "Enable notifications" button to checkbox. (easy)
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Wed, 05 Mar 2014 07:37:31 -0000
#9426: Change "Enable notifications" button to checkbox. (easy)
-----------------------------------------+----------------------------
Reporter: mmadia | Owner: pulkomandy
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Preferences/Notifications | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-----------------------------------------+----------------------------
Comment (by pulkomandy):
There are some more improvements to do:
* kServer and fServer are not good names. kToggleNotifications and
fNotificationsEnabled may be better (or something like this)
* in GenralView::MessageReceived, the action to take depends on
_IsServerRunning() only. There is a risk of the checkbox being out of
sync. It should decide the action depending on the checkbox state (you can
check using the "be:value" field of the message, or using
fServer->Value()). If the action is "enable notifications", it should
check that the server is not running. If the action is "disable
notifications", the current code will show an alert, which sonds right.
--
Ticket URL: <https://dev.haiku-os.org/ticket/9426#comment:4>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
