[haiku-bugs] Re: [Haiku] #9672: False positive of alert prompt.
- From: "puckipedia" <trac@xxxxxxxxxxxx>
- Date: Sun, 22 Dec 2013 21:48:23 -0000
#9672: False positive of alert prompt.
---------------------------------------+----------------------------
Reporter: mmadia | Owner: axeld
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Applications/DriveSetup | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
---------------------------------------+----------------------------
Comment (by puckipedia):
Replying to [comment:3 korli]:
> This is an API change, this means you checked that no code used the
dev_t returned by this method, right?
Yes, I checked that no code used the dev_t, all only used the status_t.
Replying to [comment:4 siarzhuk]:
> BTW, dev_t returned by this method is casted silently into status_t and
checked for error as (result < B_OK). After style fixing it in hrev45277
to more correct using of status_t as (result != B_OK) DriveSetup started
to complain about failed mount operation.
This was the original patch (see GCI page), but I changed it mostly
because all uses just use the status_t portion.
I added a new patch containing the two style fixes.
--
Ticket URL: <http://dev.haiku-os.org/ticket/9672#comment:5>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
