[haiku-bugs] Re: [Haiku] #9744: Greek (Extended).Keymap – Greek Polytonic keyboard
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Sun, 05 May 2013 23:12:23 -0000
#9744: Greek (Extended).Keymap – Greek Polytonic keyboard
----------------------------------+-----------------------------
Reporter: greekboy | Owner: axeld
Type: enhancement | Status: new
Priority: high | Milestone: R1
Component: Preferences/Keymap | Version: R1/alpha4.1
Resolution: | Keywords: Greek Polytonic
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------+-----------------------------
Comment (by axeld):
Thanks a lot for your patches, but please use git format-patch in the
future.
About the binary compatibility problem: applications will not crash by
your changes (since the only way to retrieve a key_map structure is via
`get_key_map()`, and that one is safe in this regard).
However, even if we change the version of that structure, old applications
using the table will use it incorrectly, as the location of things
changed. You could fix this by not extending the existing arrays, but
rather by adding new ones to the end of the structure. Unfortunately, this
would make pretty much all changes rather messy. I also believe (but
haven't checked) that you break the on-disk format of our binary keymap
files -- this would not be acceptable at all.
Since we can determine whether an application has been linked against
Haiku libraries, or BeOS libraries, we could also provide the new
structure only for new applications. This would require a mechanism to
convert the structures for old apps, though.
Do you understand what I'm trying to explain here, Hristos?
BTW, we do not add authors to the header files; it wasn't missing by
accident. And if you actually have to add such a list, please fill it from
its log history as a courtesy to the other authors.
--
Ticket URL: <http://dev.haiku-os.org/ticket/9744#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
