[haiku-bugs] [Haiku] #9813: [cddb_daemon] slash clash
- From: "ttcoder" <trac@xxxxxxxxxxxx>
- Date: Tue, 04 Jun 2013 18:20:01 -0000
#9813: [cddb_daemon] slash clash
---------------------+------------------------------
Reporter: ttcoder | Owner: nobody
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Servers | Version: R1/Development
Keywords: | Blocked By:
Blocking: | Has a Patch: 0
Platform: All |
---------------------+------------------------------
The CDDB daemon parsing code has a feature where a "/" slash in a Track
title is interpreted as a delimiter for a track specific artist (i.e. an
artist that overrides the disc-wide artist for that particular track):
http://cgit.haiku-
os.org/haiku/tree/src/servers/cddb_daemon/cddb_server.cpp#n259
This causes trouble for track titles that include... a slash! Like track
TTITLE0 on this disk: http://www.freedb.org/freedb/misc/5d0a5908
The www.freedb.org FAQ does mention that feature, but it says it only
applies if the disc-wide artist is set to "Various" :
http://www.freedb.org/en/faq.3.html#22
For highest compatibility, cddb_server.cpp:259 should test for "Various"
before applying the overriden artist feature. If the artist is not
"Various" but e.g. "Doug Smith" then the slash in title should be
interpreted as-is... with the required defensive programming when using
that value for creating files of course. Indeed there are provisions for
that elsewhere in the code (look for {{{ReplaceSet("/", " ")}}} calls in
several places, including when processing the title and artist fields) so
the fact that "Various" is not taken into account seems to be a simple
overlook.
--
Ticket URL: <http://dev.haiku-os.org/ticket/9813>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
