[haiku-bugs] Re: [Haiku] #11306: "package add" no longer works

  • From: "mmlr" <trac@xxxxxxxxxxxx>
  • Date: Thu, 09 Oct 2014 21:51:16 -0000

#11306: "package add" no longer works
--------------------------------+----------------------------
   Reporter:  ttcoder           |      Owner:  bonefish
       Type:  bug               |     Status:  closed
   Priority:  normal            |  Milestone:  R1
  Component:  Kits/Package Kit  |    Version:  R1/Development
 Resolution:  fixed             |   Keywords:
 Blocked By:                    |   Blocking:
Has a Patch:  0                 |   Platform:  All
--------------------------------+----------------------------
Changes (by mmlr):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixed in hrev47990. As per the suggestion above,
 {{{_UnwriteLastPartialChunk()}}} now uses
 {{{ReadAndDecompressChunkData()}}} directly. As it already has all the
 needed information, this was a really simple fix.

 I also tested my hypothesis that this bug would always corrupt the last
 partial chunk of a package on update, which was indeed the case. Since the
 package created in the provided test case only consisted of a single
 chunk, it made the error more obvious. In other use cases the corruption
 would probably have gone unnoticed more easily.

 Thanks to ttcoder for the nice test case and Ingo for the heads up on the
 elegant solution.

--
Ticket URL: <https://dev.haiku-os.org/ticket/11306#comment:11>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: