#11518: Implement BFont::Blocks
--------------------------------+------------------------------------------
Reporter: dsizzle | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Kits/Interface | Version: R1/Development
Kit | Keywords: bfont, blocks, font, unicode
Resolution: | Blocking: 3651
Blocked By: | Platform: All
Has a Patch: 1 |
--------------------------------+------------------------------------------
Comment (by korli):
Sounds better.
1/ Where comes kUnicodeBlockMap's content from? Why not keep that private
in ServerFont.cpp?
2/ in ParseFcMap() you can replace the while loop with a for loop. If
there are 32 bits, why do you check for 0x8000 instead of 0x80000000 ?
2/ Error handling seems to be missing in GetUnicodeBlocks().
FcFreeTypeCharSet can return null, FcCharSetFirstPage can return
FC_CHARSET_DONE
3/ A few style issues:
* in Font.h and UnicodeBlockObjects.h, don't delete blank lines.
* in ServerFont.cpp, a new line is missing after the return type of
functions. 'for' doesn't need a new line before the brace block.
"(rangeStart-1)" should be "(rangeStart - 1)". "int i=0" should be "int i
= 0", etc..
4/ a 'git format-patch' would be needed with a commit message, explaining
the changes in API (why it is harmless) plus the implementation.
--
Ticket URL: <https://dev.haiku-os.org/ticket/11518#comment:14>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
