#11518: Implement BFont::Blocks
--------------------------------+------------------------------------------
Reporter: dsizzle | Owner: nobody
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Kits/Interface | Version: R1/Development
Kit |
Resolution: | Keywords: bfont, blocks, font, unicode
Blocked By: | Blocking: 3651
Has a Patch: 1 | Platform: All
--------------------------------+------------------------------------------
Comment (by axeld):
Thanks for the detailed explanations! Is there any reason for the
unicode_block_range to be public, then?
About the coding style; we usually try to gradually improve the codebase
when we touch a file (as the coding style unfortunately changed over
time). For example, when I intend to work on a file, I look over it, and
fix any style issues first in a separate commit (as the style issues won't
then distract from my actual interest, and I know it's hard for me to
resist to fix them :-)).
A separate style cleanup patch is always welcome, but it's also okay if
only the new code follows the coding style, if the file should actually
follow our coding style (there is obviously no point in changing third
party code this way). In any case, there is no need for a further update
of your patch because of this.
And about ServerFont.cpp, line 514: yes, we're not "logical" about multi-
line statements; anything that visually occupies more than one line (even
if one is only a comment) is considered a multi-line statement, and
deserves its own block.
In general, our coding style tries to make reading and grasping the code
as easy as possible, without any cruft that could distract from the actual
code, but a lot of it is, of course, caused by habituation. Descriptive
naming is probably the most important part of it, though.
Anyway, I'd say the patch is good to go. If no one speaks up, I'll try to
commit it later today. Thanks a lot, also for your endurance! :-)
--
Ticket URL: <https://dev.haiku-os.org/ticket/11518#comment:35>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
