#13513: [BTRFS] Code refactoring and integrate with fs_shell
---------------------------+----------------------------
Reporter: hyche | Owner: nobody
Type: enhancement | Status: new
Priority: normal | Milestone: Unscheduled
Component: - General | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
---------------------------+----------------------------
Comment (by pulkomandy):
{{{
#!cpp
// This needs to be included after the fs_shell wrapper
#include <zlib.h>
#include <new>
#include "fssh_api_wrapper.h"
}}}
They appear to be included before the wrapper, now?
I'm not sure about the indentation style for inline methods braces:
{{{
#!cpp
void ThisLooksStrange {
DoStuff(); }
}}}
I would stick with how it was before:
{{{
#!cpp
void ThisLooksBetter
{ DoStuff(); }
}}}
We should adjust the coding guidelines if it is not mentionned there, and
the checkstyle tool if it detects it. The tool is not always right.
Maybe someone else can comment on the exact formatting to use in that
case?
I think you can remove the libHaikuCompat thing in your jamfile (and in
bfs_shell one too, if it's still there). This was used to run the tools on
BeOS, but we don't support that anymore.
--
Ticket URL: <https://dev.haiku-os.org/ticket/13513#comment:7>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
