[haiku-bugs] Re: [Haiku] #13513: [BTRFS] Code refactoring and integrate with fs_shell

  • From: "hyche" <trac@xxxxxxxxxxxx>
  • Date: Fri, 19 May 2017 09:23:24 -0000

#13513: [BTRFS] Code refactoring and integrate with fs_shell
---------------------------+----------------------------
   Reporter:  hyche        |      Owner:  nobody
       Type:  enhancement  |     Status:  new
   Priority:  normal       |  Milestone:  Unscheduled
  Component:  - General    |    Version:  R1/Development
 Resolution:               |   Keywords:
 Blocked By:               |   Blocking:
Has a Patch:  1            |   Platform:  All
---------------------------+----------------------------

Comment (by hyche):

 Replying to [comment:7 pulkomandy]:

{{{
#!cpp
// This needs to be included after the fs_shell wrapper
#include <zlib.h>
#include <new>

#include "fssh_api_wrapper.h"
}}}

They appear to be included before the wrapper, now?
 After something mean it will be done first, right ? I'm confused now.

I'm not sure about the indentation style for inline methods braces:

{{{
#!cpp
    void    ThisLooksStrange {
                DoStuff(); }
}}}

I would stick with how it was before:

{{{
#!cpp
    void    ThisLooksBetter
                { DoStuff(); }
}}}
 There are 2 styles like this in the code base, I just chose one and
 rewrite.
 As you can see [http://xref.plausible.coop/source/xref/haiku/src/add-
 ons/kernel/file_systems/btrfs/btrfs.h#75 here] and
 [http://xref.plausible.coop/source/xref/haiku/src/add-
 ons/kernel/file_systems/btrfs/btrfs.h#110 here]


I think you can remove the libHaikuCompat thing in your jamfile (and in
 bfs_shell one too, if it's still there). This was used to run the tools on
 BeOS, but we don't support that anymore.
 Got it!

--
Ticket URL: <https://dev.haiku-os.org/ticket/13513#comment:8>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts:

  1. Home
  2. haiku-bugs
  3. Archive
  4. 05-2017