[haiku-bugs] Re: [Haiku] #14626: network device config misalignment

  • From: "Haiku" <trac@xxxxxxxxxxxx>
  • To: undisclosed-recipients: ;
  • Date: Wed, 19 Dec 2018 14:17:17 -0000

#14626: network device config misalignment
--------------------------------+----------------------------
   Reporter:  kallisti5         |      Owner:  nobody
       Type:  bug               |     Status:  new
   Priority:  normal            |  Milestone:  Unscheduled
  Component:  Kits/Network Kit  |    Version:  R1/Development
 Resolution:                    |   Keywords:
 Blocked By:                    |   Blocking:
Has a Patch:  0                 |   Platform:  All
--------------------------------+----------------------------

Comment (by kallisti5):

 I'm not 100% sure that something doesn't come in later and call SetName,
 but the NULL check at https://git.haiku-
 os.org/haiku/tree/src/kits/network/libnetapi/NetworkSettings.cpp#n585
 means it's a big unknown.

 I think the NULL check is there as a generic "if no NIC name, apply static
 IP to the first nic", however that creates a lot of unknown behavior.

 If someone swaps a NIC, we really should start ignoring the configuration
 for it since with multiple NIC's things get a bit complex.

 Maybe that NULL check should be returned as B_ENTRY_NOT_FOUND?

-- 
Ticket URL: <https://dev.haiku-os.org/ticket/14626#comment:3>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: