#16488: Icon-O-Matic Properties Input Field entries out of scope
---------------------------------+--------------------------
Reporter: roiredxsoto | Owner: jscipione
Type: bug | Status: assigned
Priority: normal | Milestone: Unscheduled
Component: Kits/Interface Kit | Version: R1/beta2
Resolution: | Keywords: Icon-O-Matic
Blocked By: | Blocking:
Platform: All |
---------------------------------+--------------------------
Comment (by jscipione):
In my latest patch set [0] I have reverted all the Icon-O-Matic changes
that I previously made and once again allowed Icon-O-Matic to work
unmodified. The problematic code in Icon-O-Matic is a work-around for bugs
that have now been fixed in BTextView so can be taken out... but I've
changed BTextView such that Icon-O-Matic text views will continue to work
even if we don't take the workaround out. See the code example above. This
code has been ensured to work by only adding the default insets when the
text rect is set to text view bounds. While this means that we may not get
the default insets in some places where we want them, it also means that
the insets will only get applied one time, and not over and over again.
And not getting the default insets applied where they should in some
places is not nearly as big a deal.
[0] https://review.haiku-os.org/c/haiku/+/3152
--
Ticket URL: <https://dev.haiku-os.org/ticket/16488#comment:8>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
