[haiku-bugs] Re: [Haiku] #6227: Terminal TermParse::EscParse() 2 issues.

  • From: "h.z" <trac@xxxxxxxxxxxx>
  • Date: Wed, 23 Jun 2010 12:21:28 -0000

#6227: Terminal TermParse::EscParse() 2 issues.
-----------------------------------+----------------------------------------
 Reporter:  h.z                    |       Owner:  jackburton
     Type:  bug                    |      Status:  new       
 Priority:  normal                 |   Milestone:  R1        
Component:  Applications/Terminal  |     Version:  R1/alpha2 
 Keywords:                         |   Blockedby:            
    Patch:  0                      |    Platform:  All       
 Blocking:                         |  
-----------------------------------+----------------------------------------

Comment(by h.z):

 I notice new class methods are used now, so I think need some time to do
 some debugging to see what happens after these changes.

 One quick fix for issue 1 just like this, working good at UTF-8 conversion
 but its not a good way, I think. The problems should come from
 TermParse::EscParse().

 ---BasicTerminalBuffer.cpp---
 void
 BasicTerminalBuffer::InsertChar(UTF8Char c, uint32 width, uint32
 attributes)
 {
 //debug_printf("BasicTerminalBuffer::InsertChar('%.*s' (%d), %#lx)\n",
 //(int)c.ByteCount(), c.bytes, c.bytes[0], attributes);
         if ((int32)width == FULL_WIDTH)
                 attributes |= A_WIDTH;

 +       if (c.IsFullWidth())
 +{
 +               attributes |= A_WIDTH;
 +               width *= 2;
 +}

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6227#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: