[haiku-bugs] Re: [Haiku] #6318: Fixing listport output and changing it to a localized BApplication
- From: "Karvjorm" <trac@xxxxxxxxxxxx>
- Date: Fri, 16 Jul 2010 09:15:34 -0000
#6318: Fixing listport output and changing it to a localized BApplication
--------------------------+-------------------------------------------------
Reporter: Karvjorm | Owner: pulkomandy
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: - General | Version: R1/alpha2
Resolution: | Keywords: listport localization
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
--------------------------+-------------------------------------------------
Comment (by Karvjorm):
Replying to [comment:4 axeld]:
> I'm against applying this patch for the following reasons:
> * listport is a very simple command, there is no reason to move it into
its own subdirectory
There are also some other commands with subdirectories, as ideinfo,
listdev and playsound.
One advantage with a subdirectory is that you can include also a resource
file with app_flags. Before defining application as a B_BACKGROUND_APP (or
whatever it was) the new BApplication application popped up in the deskbar
once during each run and then disappeared immediately.
> * it's called "listport", not ListPort, so the source file should match
That's right, but you can easily fix this by changing "Application
listport" and "DoCatalogs listport" to Jamfile. I used this form to be
sure that the applications do not be mixed during he "evaluation period".
> * while I heavily dislike having localized command line applications, I
guess others do think otherwise. Still, if possible, I would like to have
the command line applications in English, while the rest of the system
follows the configured language by default. Not sure, if this is possible
already.
Command line applications are localized in Linux and I like it. You can
easily change locale settings to English, if you want to use English
command line commands.
> * You said "does not look so good": what exactly do you mean, and what
exactly did you change?
Here is an example of the old output
{{{
TEAM 101 (/boot/system/servers/media_server):
ID name capacity queued
----------------------------------------------------
98370 tmp_rport0 1 0
98371 tmp_rport1 1 0
98372 tmp_rport2 1 0
102469 AppLooperPort 200 0
102473 a<app_server 100 0
102474 a<101:x-vnd.Be.media-server 50 0
114767 __media_server_port 64 0
176236 AddOnMonitor 200 0
245885 _BMediaRoster_ 200 0
245886 media reply port 1 0
}}}
and here is output after my fixes:
{{{
TEAM 101 (/boot/system/servers/media_server):
ID name capacity queued
-----------------------------------------------------------
98370 tmp_rport0 1 0
98371 tmp_rport1 1 0
98372 tmp_rport2 1 0
102469 AppLooperPort 200 0
102473 a<app_server 100 0
102474 a<101:x-vnd.Be.media-server 50 0
114767 __media_server_port 64 0
176236 AddOnMonitor 200 0
245885 _BMediaRoster_ 200 0
245886 media reply port 1 0
}}}
> * Localization changes should be separated from other changes.
Yes, this this is right, but included them both here in new application. I
could do a fix patch for the listport.c file also. I'll try to include it
here as a separate patch.
--
Ticket URL: <http://dev.haiku-os.org/ticket/6318#comment:5>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
