[haiku-bugs] Re: [Haiku] #8911: Write a new BSoundConsumer class to replace the SoundConsumer class
- From: "hamish" <trac@xxxxxxxxxxxx>
- Date: Thu, 16 Jan 2014 03:53:05 -0000
#8911: Write a new BSoundConsumer class to replace the SoundConsumer class
------------------------------+----------------------------
Reporter: korli | Owner: hamish
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Kits/Media Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------+----------------------------
Comment (by hamish):
Hi Barrett,
Thanks for the patch! Haven't looked very deeply yet but there's some
issues I can see:
* Input nodes retrieved from the roster should be released upon
disconnection.
* Local variable and function naming style is sometimes wrong
(shouldLookLikeThis).
* NULL should be used for null pointers, not 0.
* snprintf should be used instead of sprintf.
* Opening brace of class definition should be on the same line i.e. `class
BMediaRecorder {`
Also, why provide a function for accessing the BMediaRecorder's internal
node?
--
Ticket URL: <http://dev.haiku-os.org/ticket/8911#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
