[haiku-bugs] Re: [Haiku] #8911: Write a new BSoundConsumer class to replace the SoundConsumer class
- From: "korli" <trac@xxxxxxxxxxxx>
- Date: Tue, 11 Feb 2014 08:49:24 -0000
#8911: Write a new BSoundConsumer class to replace the SoundConsumer class
------------------------------+----------------------------
Reporter: korli | Owner: hamish
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Kits/Media Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------+----------------------------
Comment (by korli):
Hi Barrett! Thanks for the patch! I know the code before might not be
coding style compliant and your patch already fixed some but not
introducing new issues would be nice :)
* ProcessFunc and NotifyFunc should be placed in the class.
* no blank line after the copyright header in header files.
* two blank lines after the header guard.
* MediaRecorderNode.h, MediaRecorderNode.cpp and MediaRecorder.cpp don't
use the usual copyright header.
* BMediaRecorder constructor parameter names don't match with
BMediaRecorderNode.
* What is StNodeRelease? One should probably use/extend AutoDeleter.h.
Parameter and members could use better names anyway.
* the protected scope constructors for BMediaRecorder have no
implementations. Ditto for the equal operator.
* I don't understand why one should now provide a thread priority, as it
should depend of the run mode and the media type. Use
suggest_thread_priority() and implement SetRunMode(). One should implement
media_realtime_init_thread() in the media kit someday :)
--
Ticket URL: <https://dev.haiku-os.org/ticket/8911#comment:14>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
