[haiku-bugs] Re: [Haiku] #8990: intel partiton addon allows creating partitions > 2TB (easy)
- From: "kushalsingh007" <trac@xxxxxxxxxxxx>
- Date: Mon, 26 Jan 2015 13:41:31 -0000
#8990: intel partiton addon allows creating partitions > 2TB (easy)
------------------------------------------+----------------------------
Reporter: luroh | Owner: bonefish
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Partitioning Systems/Intel | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------------------+----------------------------
Comment (by kushalsingh007):
Replying to [comment:19 pdziepak]:
> The real problem with the posted patch was (and still is in v2) that it:
1) breaks the size check by hardcoding 512 byte sector size, 2) adds
offset check with hardcoded 512 byte sector size. The correct way to get
the sector size is to use `BlockSize()` as it is done for the currently
used size check. As long as these issues are not corrected in the patch it
has my "nacked-by".
Since BlockSize() right now is returning the wrong values, using it in the
patch would be a bad idea. As for instance I have 2.95TB (512 sector size)
disk , I can initialize it to Be-File System first and then create intel
partition map (which is wrong). A patch fixing the code for BlockSize()
should be different. And can be added later. I agree that this patch is
not the final solution to the problem. Once I find the problem with
BlockSize() , I'll update the patch.
--
Ticket URL: <https://dev.haiku-os.org/ticket/8990#comment:20>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
