[haiku-bugs] Re: [Haiku] #8990: intel partiton addon allows creating partitions > 2TB (easy)
- From: "pdziepak" <trac@xxxxxxxxxxxx>
- Date: Mon, 26 Jan 2015 11:00:40 -0000
#8990: intel partiton addon allows creating partitions > 2TB (easy)
------------------------------------------+----------------------------
Reporter: luroh | Owner: bonefish
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Partitioning Systems/Intel | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
------------------------------------------+----------------------------
Comment (by pdziepak):
Replying to [comment:7 phoudoin]:
> Replying to [comment:6 pdziepak]:
> > 1. This patch assumes sector size to be 512 which may not be true
(e.g. 4Kn).
>
> Well, MBR partionning assume 512 bytes sectors, real or emulated (512e).
> AFAICT, support of native 4096 bytes sectors needs using GPT
partitionning.
I don't think that MBR assumes anything. Its data structures just use
sector as a base unit and the size of the sector isn't really important
here.
> > 2. What was wrong with `partition->Size() / partition->BlockSize() <
UINT32_MAX` ?
>
> It was not checking that partition *offset* was also within 32 bits
limits?
That's not what I was asking about. I understand the problem with the
partition offset. My question is, what was wrong with that line of code
that it needed to be changed?
--
Ticket URL: <https://dev.haiku-os.org/ticket/8990#comment:9>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
