[haiku-bugs] Re: [Haiku] #11518: Implement BFont::Blocks

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Wed, 03 May 2017 15:02:31 -0000

#11518: Implement BFont::Blocks
--------------------------------+------------------------------------------
   Reporter:  dsizzle           |      Owner:  nobody
       Type:  enhancement       |     Status:  assigned
   Priority:  normal            |  Milestone:  R1
  Component:  Kits/Interface    |    Version:  R1/Development
  Kit                           |
 Resolution:                    |   Keywords:  bfont, blocks, font, unicode
 Blocked By:                    |   Blocking:  3651
Has a Patch:  1                 |   Platform:  All
--------------------------------+------------------------------------------

Comment (by axeld):

 I get a compilation error:
 {{{
 cc1plus: warnings being treated as errors
 /boot/home/develop/haiku/haiku/src/servers/app/ServerFont.cpp: In function
 `void ParseFcMap(unsigned int *, unsigned int, unicode_block &)':
 /boot/home/develop/haiku/haiku/src/servers/app/ServerFont.cpp:507:
 warning: `int32 foundStartBlock' might be used uninitialized in this
 function
 }}}
 And it looks complicated enough that it might be an actual issue.

 Also, I noticed some more style issues you could fix on the way: :-)
 * There are extraneous parenthesis in the if-term in ServerFont.cpp line
 520.
 * Please change your editor settings to remove whitespace at the end of a
 line; your patch introduces quite a number of such cases.

--
Ticket URL: <https://dev.haiku-os.org/ticket/11518#comment:38>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.

Other related posts: