[haiku-bugs] Re: [Haiku] #6831: New StyledEdit features: word count & show document as read-only
- From: "humdinger" <trac@xxxxxxxxxxxx>
- Date: Thu, 18 Nov 2010 10:37:50 -0000
#6831: New StyledEdit features: word count & show document as read-only
--------------------------------------+------------------------------
Reporter: negusnyul | Owner: korli
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/StyledEdit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
--------------------------------------+------------------------------
Comment (by humdinger):
Hey negusnyul! Welcome! [[BR]]
I'm not really sure about the "read-only" feature. At least I have never
felt the need for it. If I don't want to save an accidentally altered
document I just click "Don't save" in the alert popping up when closing
the document. Maybe others have a different opinion. If so, I'd suggest to
rename the menu item to "Lock" or something to avoid confusion with actual
read-only-ness.
The word count might be handy. If you feel like it, you could rename it to
"Info" and add a few more essentials. See Pe's "Statistics" in
"Window|File Options..." for inspiration. One could also take the
currently selected text into account to show something like {{{ Lines:
124 of 1928 }}}.
For the coding style I defer to the local coding style police :)[[BR]]
All I can say is that the use of the curly brackets in if/for/switch-case
blocks should be re-read in the [http://www.haiku-os.org/development
/coding-guidelines Guidelines]. The opening bracket should be on the same
line, if needed at all. Also, respect those 80 chars/line.
In my quite unexperienced opinion, it's a rather fine first patch, though
it's always a good idea to discuss a planned feature addition beforehand.
We have to be wary against feature-creep and a fix of something is always
less controversial.
--
Ticket URL: <http://dev.haiku-os.org/ticket/6831#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
