[haiku-bugs] Re: [Haiku] #6831: New StyledEdit features: word count & show document as read-only
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Thu, 18 Nov 2010 21:22:37 -0000
#6831: New StyledEdit features: word count & show document as read-only
--------------------------------------+------------------------------
Reporter: negusnyul | Owner: korli
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/StyledEdit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
--------------------------------------+------------------------------
Comment (by axeld):
Thanks, and I've got some more remarks for you:
* your patch also contains some unrelated changes. Is there any particular
reason you introduce new members for the menu items? Since they are never
used after construction, there is no need to have an extra member for them
(neither for the word count menu item). In any case, you should always try
to make your patches as focussed as possible; better make two patches for
unrelated changes.
* You also introduce a bug with the member changes, at least line 224
still points to the old name when calling SetTarget() (which should break
paste functionality).
* Since you also count lines, and characters "word count" is actually not
the best name "Statistics" or something like it would be better. Also, a
method name that actually implies that it also shows an alert would be
preferred, for example ShowStatistics().
Anyway, thanks for working on this, and I hope you don't get shied away
easily :-)
--
Ticket URL: <http://dev.haiku-os.org/ticket/6831#comment:5>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
