[haiku-bugs] Re: [Haiku] #6831: New StyledEdit features: word count & show document as read-only
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Fri, 19 Nov 2010 21:49:40 -0000
#6831: New StyledEdit features: word count & show document as read-only
--------------------------------------+------------------------------
Reporter: negusnyul | Owner: korli
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/StyledEdit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
--------------------------------------+------------------------------
Comment (by axeld):
Replying to [comment:6 negusnyul]:
> (Third version of the patch attached.)
Great! I've got only another remark that I missed before (sorry!): you've
used uint64 for the size of the strings - that is a bit more than what can
the put into memory, and both BString::Length() (that you used), as well
as BTextView::TextLength() (that you should have used) return an int32
(which probably should have been a size_t), which should therefore be
enough for length, and the index. Since it's only a small change, I could
fix this for you, too, if you prefer.
> "Anyway, thanks for working on this, and I hope you don't get shied away
easily :-)"
> Its not that easy to shy me away :) Also, I would like to see this patch
in trunk sooner or later, so I keep working on it if needed. :)
Is that a promise? Because we could keep this patch from being applied
until StyledEdit is a full featured word processor, if you like to ;-)
--
Ticket URL: <http://dev.haiku-os.org/ticket/6831#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
