[haiku-bugs] Re: [Haiku] #8270: [HDA] very quiet on Lenovo laptop (due to hda mixer?)

  • From: "ttcoder" <trac@xxxxxxxxxxxx>
  • Date: Mon, 24 Sep 2012 14:38:40 -0000

#8270: [HDA] very quiet on Lenovo laptop (due to hda mixer?)
---------------------------------+----------------------------
   Reporter:  ttcoder            |      Owner:  korli
       Type:  bug                |     Status:  closed
   Priority:  normal             |  Milestone:  R1
  Component:  Drivers/Audio/HDA  |    Version:  R1/Development
 Resolution:  fixed              |   Keywords:
 Blocked By:                     |   Blocking:
Has a Patch:  0                  |   Platform:  All
---------------------------------+----------------------------

Comment (by ttcoder):

 It appears it does! However there ''is'' another regression with that
 change, namely #8333 is back (line-in/microphone-in no longer works).
 (maybe I should cross-post this comment there for that matter hmm)

 In other words,
 - I did a git pull to be up to date, rebuilt to ensure there's no
 regression or anything.
 - I then applied these changes (I think these are what you are referring
 to axel):

 {{{
 @@ -947,7 +947,7 @@ hda_widget_find_input_path(hda_audio_group*
 audioGroup, hda_widget* widget,
                 case WT_PIN_COMPLEX:
                         // already used
                         if ((widget->flags
 -                                       & (WIDGET_FLAG_INPUT_PATH |
 WIDGET_FLAG_OUTPUT_PATH)) != 0)
 +                                       & (WIDGET_FLAG_INPUT_PATH/* |
 WIDGET_FLAG_OUTPUT_PATH*/)) != 0)
                                 return false;

                         if (PIN_CAP_IS_INPUT(widget->d.pin.capabilities))
 {
 @@ -968,7 +968,7 @@ TRACE("      %*sinput: added input widget %ld\n",
 (int)depth * 2, "", widget->no
                 {
                         // already used
                         if ((widget->flags
 -                                       & (WIDGET_FLAG_INPUT_PATH |
 WIDGET_FLAG_OUTPUT_PATH)) != 0)
 +                                       & (WIDGET_FLAG_INPUT_PATH/* |
 WIDGET_FLAG_OUTPUT_PATH*/)) != 0)
                                 return false;
 }}}

 and then line-in no longer works (though sound output is unchanged, still
 good).

 Maybe running a "diff" on the syslog with and without the chand could give
 direct hints (on my syslog and/or yours I guess) on why it triggers a
 regression of ticket #8333 and progression for you..

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/8270#comment:19>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: