[haiku-bugs] Re: [Haiku] #8987: ps2: initial setup of command byte failed
- From: "mmlr" <trac@xxxxxxxxxxxx>
- Date: Mon, 08 Oct 2012 12:03:28 -0000
#8987: ps2: initial setup of command byte failed
----------------------------------+----------------------------------------
Reporter: x-ist | Owner: siarzhuk
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: | Version: R1/Development
Drivers/Keyboard/PS2 | Keywords: ps2 keyboard touchpad OHCI
Resolution: | Blocking:
Blocked By: | Platform: All
Has a Patch: 1 |
----------------------------------+----------------------------------------
Comment (by mmlr):
Replying to [comment:24 x-ist]:
> Replying to [comment:23 mmlr]:
> > The first comment should be rewritten as it sounds a bit "constructed"
now ...
> I just could try to guess what a better comment might be like. It
motivates the change by means of the observations I made and your
suggestion. I don't have hard arguments unfortunately. The other
objections will be resolved of course.
I more meant it was a bit rough to read, not that the content was
incorrect in any way. I'd suggest making it a bit more elaborate as well.
Something like: "When the handover from SMM takes place, all interrupts
are routed to the OS. As we don't yet have an interrupt handler installed,
this may cause interrupt storms if the firmware does not disable the
interrupts during handover. Therefore we disable interrupts before
requesting ownership. We have to keep the ownership change interrupt
enabled though, as otherwise the SMM will not be notified of the ownership
change request we trigger below." More or less summing up the discussion
in here so that one doesn't have to wonder next time.
--
Ticket URL: <http://dev.haiku-os.org/ticket/8987#comment:25>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
