[haiku-bugs] Re: [Haiku] #3651: Possible CharacterMap enhancements (easy)
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Tue, 25 Nov 2014 07:45:39 -0000
#3651: Possible CharacterMap enhancements (easy)
-----------------------------------------+---------------------------
Reporter: humdinger | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/CharacterMap | Version: R1/pre-alpha1
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-----------------------------------------+---------------------------
Comment (by pulkomandy):
Hi,
You can use {{{git rebase -i}}} to edit your git history and merge or
split patches. This would be cleaner and would make them easier to review.
Patch 1 applied in hrev48371.
I took another look at patch 2 and I see another strange thing : you have
added a call to {{{fFontSizeSlider->SetLabel(displayName);}}} right after
creating the slider with that name already, why is that needed?
On patch 7: unfortunately the list of directories to monitor is a bit
bigger. You should use the newly introduced BPathFinder class to get the
directories ({{{headers/os/storage/PathFinder.h}}}).
Patch 9: this assumes "w" is the largest character, which may be true only
for latin fonts. I'm not sure there is a better solution, however. Also
the patch now depends on patch 7 so I can't apply it.
--
Ticket URL: <https://dev.haiku-os.org/ticket/3651#comment:16>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
