[haiku-bugs] Re: [Haiku] #3651: Possible CharacterMap enhancements (easy)
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Mon, 24 Nov 2014 07:35:31 -0000
#3651: Possible CharacterMap enhancements (easy)
-----------------------------------------+---------------------------
Reporter: humdinger | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/CharacterMap | Version: R1/pre-alpha1
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-----------------------------------------+---------------------------
Comment (by pulkomandy):
Hi,
Patch 1:
In the (unlikely) "character not mapped" case, shouldn't
SelectblockForCharacter return, rather than break? What happens if you
call Select with an invalid block number? If this is done on purpose
(didn't check the code, do we have an "unmapped" block at the end of the
list?), a comment should be added to remember people reading the code of
that. Something like this:
{{{
// Character is not mapped, we will scroll to the special "unmapped" block
at the end of the list
}}}
Patch 2:
It looks like the code for handling displayName would be much simpler if
you used a {{{BString}}} instead of a {{{char*}}}. I think the " > " is
not needed (we use "DejaVu Sans Book" elsewhere, with "DejaVu Sans" the
family and "Book" the style).
Thanks for the patches!
--
Ticket URL: <https://dev.haiku-os.org/ticket/3651#comment:12>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
