[haiku-bugs] Re: [Haiku] #3651: Possible CharacterMap enhancements (easy)
- From: "dsizzle" <trac@xxxxxxxxxxxx>
- Date: Tue, 25 Nov 2014 05:36:08 -0000
#3651: Possible CharacterMap enhancements (easy)
-----------------------------------------+---------------------------
Reporter: humdinger | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Applications/CharacterMap | Version: R1/pre-alpha1
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-----------------------------------------+---------------------------
Comment (by dsizzle):
You're welcome for the patches! Thanks for reviewing them pulkomandy.
For Patch 1, the {{{break;}}} actually will exit the for loop, and then
fall out of the function {{{SelectBlockForCharacter}}} without calling the
select command. It is a stylistic difference, but if prefer a
{{{return;}}} then I'm happy to change it.
For Patch 2, I rewrote the C-style string lines to use BString...much much
nicer! I don't know how to combine patches so I uploaded a second patch.
I also added a path for Enhancement 7 - node monitoring font directories
to rebuild the font menu on the fly. It monitors
B_SYSTEM_FONTS_DIRECTORY and B_USER_FONTS_DIRECTORY, which seemed correct
but the system font dir is read-only, and the user font dir has a slightly
different path (that doesn't exist in my installation). Are those
appropriate directories to monitor?
--
Ticket URL: <https://dev.haiku-os.org/ticket/3651#comment:13>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
