[haiku-bugs] Re: [Haiku] #8954: USB3 support

  • From: "jessicah" <trac@xxxxxxxxxxxx>
  • Date: Sat, 28 Jun 2014 19:03:47 -0000

#8954: USB3 support
---------------------------+----------------------------
   Reporter:  dsjonny      |      Owner:  korli
       Type:  enhancement  |     Status:  assigned
   Priority:  high         |  Milestone:  Unscheduled
  Component:  Drivers/USB  |    Version:  R1/Development
 Resolution:               |   Keywords:  usb3
 Blocked By:               |   Blocking:  7665, 10750
Has a Patch:  1            |   Platform:  All
---------------------------+----------------------------

Comment (by jessicah):

 Small style fix needed here (missing spaces):

     fCapabilityLength=HCI_CAPLENGTH(hciCapLength);

 Also, even though the trace statement is commented out, you should always
 use the B_PRI macros for numerical arguments:

     //TRACE("port %d status=0x%08lx\n", index, portStatus);

 And you forgot to remove the format argument when updating to B_PRI in:

     TRACE("eecp register: 0x%04" B_PRIx32 "\n", eecp);

--
Ticket URL: <https://dev.haiku-os.org/ticket/8954#comment:17>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: